Use TryNextMethod instead of Error in Intersection2 if at least one group is finite#113
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 55.82% 55.83% +0.01%
==========================================
Files 87 87
Lines 12678 12681 +3
==========================================
+ Hits 7078 7081 +3
Misses 5600 5600
🚀 New features to boost your workflow:
|
james-d-mitchell
approved these changes
Mar 30, 2026
Contributor
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Looks like a sensible change to me.
fingolfin
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the discussion in #111.
If we try to calculate
Intersection( U, V )whereUandVdo not normalise each other, then currently we throw an error. But if eitherUorVis finite, generic methods in GAP can (or should be able to) calculate this intersection.If both
UandVare infinite, we keep the error. GAP will most likely not be able to calculate the intersection, and will either throw an error itself or the command will run forever.